yangli/worldshine-redesign
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix
All checks were successful
Build And Deploy Main / build-and-deploy (push) Successful in 29s
Details

Browse Source
This commit is contained in:
Lixian Zhou
2026-03-12 16:16:14 -04:00
parent e64efa150f
commit 213de526c4
1 changed files with 33 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
client/src/components/employees/UpdateEmployee.js
View File

@@ -73,22 +73,25 @@ const UpdateEmployee = () => {
return { parsePermission, viewByPairId, editsByPairId }; return { parsePermission, viewByPairId, editsByPairId };
}, []); }, []);
const enforcePermissionPairRules = (permissionList = []) => { const applyPairRulesForToggle = (permissionList = [], permissionKey, isChecking) => {
const nextSet = new Set(permissionList); const nextSet = new Set(permissionList);
const nextList = Array.from(nextSet); const parsed = permissionPairMaps.parsePermission(permissionKey);
nextList.forEach((permissionKey) => { if (!parsed) return Array.from(nextSet);
const parsed = permissionPairMaps.parsePermission(permissionKey);
if (!parsed || parsed.type !== 'edit') return; // Checking an edit permission should also check its paired view permission.
if (isChecking && parsed.type === 'edit') {
const pairedView = permissionPairMaps.viewByPairId.get(parsed.pairId); const pairedView = permissionPairMaps.viewByPairId.get(parsed.pairId);
if (pairedView) { if (pairedView) {
nextSet.add(pairedView); nextSet.add(pairedView);
} }
}); }
permissionPairMaps.viewByPairId.forEach((viewPermission, pairId) => {
if (nextSet.has(viewPermission)) return; // Unchecking a view permission should also uncheck its paired edit permission(s).
const editPermissions = permissionPairMaps.editsByPairId.get(pairId) || []; if (!isChecking && parsed.type === 'view') {
editPermissions.forEach((editPermission) => nextSet.delete(editPermission)); const pairedEdits = permissionPairMaps.editsByPairId.get(parsed.pairId) || [];
}); pairedEdits.forEach((editPermission) => nextSet.delete(editPermission));
}
return Array.from(nextSet); return Array.from(nextSet);
}; };
const params = new URLSearchParams(window.location.search); const params = new URLSearchParams(window.location.search);
@@ -165,9 +168,10 @@ const UpdateEmployee = () => {
if (isSuperPermissionLocked) return; if (isSuperPermissionLocked) return;
setPermissions((prevPermissions) => { setPermissions((prevPermissions) => {
if (prevPermissions.includes(permissionKey)) { if (prevPermissions.includes(permissionKey)) {
return enforcePermissionPairRules(prevPermissions.filter((permission) => permission !== permissionKey)); const removed = prevPermissions.filter((permission) => permission !== permissionKey);
return applyPairRulesForToggle(removed, permissionKey, false);
} }
return enforcePermissionPairRules([...prevPermissions, permissionKey]); return applyPairRulesForToggle([...prevPermissions, permissionKey], permissionKey, true);
}); });
}; };
@@ -176,11 +180,22 @@ const UpdateEmployee = () => {
const togglePermissionGroup = (permissionItems = [], checked) => { const togglePermissionGroup = (permissionItems = [], checked) => {
if (isSuperPermissionLocked) return; if (isSuperPermissionLocked) return;
if (checked) { setPermissions((prevPermissions) => {
setPermissions((prevPermissions) => enforcePermissionPairRules(Array.from(new Set([...prevPermissions, ...permissionItems])))); let nextPermissions = [...prevPermissions];
return;
} permissionItems.forEach((permissionKey) => {
setPermissions((prevPermissions) => enforcePermissionPairRules(prevPermissions.filter((permission) => !permissionItems.includes(permission)))); const hasPermission = nextPermissions.includes(permissionKey);
if (checked && !hasPermission) {
nextPermissions = applyPairRulesForToggle([...nextPermissions, permissionKey], permissionKey, true);
return;
}
if (!checked && hasPermission) {
nextPermissions = applyPairRulesForToggle(nextPermissions.filter((permission) => permission !== permissionKey), permissionKey, false);
}
});
return Array.from(new Set(nextPermissions));
});
}; };
const triggerShowDeleteModal = () => { const triggerShowDeleteModal = () => {